-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Deprecate parallel_for and single_task overloads #16145
base: sycl
Are you sure you want to change the base?
Conversation
…xt_oneapi_kernel_properties extension Signed-off-by: Hu, Peisen <[email protected]>
…ings Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graph tests LGTM
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All deprecation messages indicate that sycl_ext_oneapi_enqueue_functions should be used instead of deprecated APIs.
But do I get it right that user also has a choice to use just regular SYCL 2020 parallel_for/single_task/parallel_for_work_group (queue and handler methods) but with kernel function object (which has a method to return properties) instead of a lambda? I.e. it seems like user doesn't have to use sycl_ext_oneapi_enqueue_functions. Maybe I am missing something.
Probably deprecation message should be fixed to indicate both available options.
Signed-off-by: Hu, Peisen <[email protected]>
Hi Artur, thanks for reviewing this! So just to let you know I've merged all commits in this PR into one in another PR #16728 to make the commit history cleaner. You can go there for further comments and check new updates. And yes I agree with you -- the main point here is that if the user want to specify (compile-time) properties for a kernel, they can no longer specify such properties as arguments passed to (overloads of) |
Sounds good, thank you! |
Signed-off-by: Hu, Peisen <[email protected]>
As the title says, added deprecation messages for such overloads in the
sycl_ext_oneapi_kernel_properties extension
, suggesting users to usesingle_task/parallel_for
overloads provided in thesycl_ext_oneapi_enqueue_functions
extension instead. (As these overloads are to be removed later as mentioned in #14785) Also fixed affected test cases by adding theWno-deprecated-declarations
build flag to let them ignore the deprecation warnings.Also one point to notice:
handler
class is actually implemented as three function overloads withrange<dimensions>...
implemented asrange<1>..., range<2>...
andrange<3>...
respectively.