Implement Dynamic Local Accessors #16573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
436771d to
c534114
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
c534114 to
19c9ad1
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
19c9ad1 to
4567acd
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
4567acd to
dfaf96f
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Jan 13, 2025
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
897dbb6 to
c7fba1a
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
c0587c9 to
9acfb29
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
5a47f11 to
4824925
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
2467538 to
d6964ff
Compare
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
force-pushed
the
fabio/dynamic_local_accessor_impl
branch
from
f13c1ec to
5c58995
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Jan 17, 2025
| assert(check_value(i, Ref, HostDataAfterUpdate[i], "PtrA After Update")); | ||
| } | ||
|
|
||
| free(PtrA, Queue); |
Bensuo
reviewed
Jan 22, 2025
| command_graph<graph_state::modifiable> Graph, const property_list &PropList) | ||
| : impl(std::make_shared<dynamic_parameter_impl>( | ||
| sycl::detail::getSyclObjImpl(Graph))) { | ||
| checkGraphPropertiesAndThrow(PropList); |
There was a problem hiding this comment.
Is this required for dynamic parameters? This checks for graph properties but any properties passed here should be dynamic_parameter properties (if/when they exist).
| // Weak ptrs to node_impls which will be updated | ||
| std::vector<std::pair<std::weak_ptr<node_impl>, int>> MNodes; | ||
| // Dynamic command-groups which will be updated | ||
| std::vector<DynamicCGInfo> MDynCGs; | ||
|
|
||
| std::shared_ptr<graph_impl> MGraph; | ||
| std::vector<std::byte> MValueStorage; | ||
|
|
||
| std::unordered_map<std::shared_ptr<sycl::detail::handler_impl>, |
There was a problem hiding this comment.
Could use a comment here explaining the purpose of this map.
| @@ -3524,14 +3528,14 @@ _ZN4sycl3_V17handler20associateWithHandlerEPNS0_6detail30UnsampledImageAccessorB | |||
| _ZN4sycl3_V17handler20memcpyToDeviceGlobalEPKvS3_bmm | |||
| _ZN4sycl3_V17handler20setKernelCacheConfigENS1_23StableKernelCacheConfigE | |||
| _ZN4sycl3_V17handler20setStateSpecConstSetEv | |||
| _ZN4sycl3_V17handler21setKernelWorkGroupMemEm | |||
There was a problem hiding this comment.
Since this symbol hasn't changed but simply moved in the ordering, I've been advised previously to remove such changes from PRs (or submit them as a separate PR) to aid in reviewing these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the dynamic_local_accessor class which adds functionality to update local_accessors in sycl graph nodes. See reble#382 for API spec.
UR PR oneapi-src/unified-runtime#2559 is also required for testing to pass