Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Temporarily disable tests requiring spirv-tools in CI #16743

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jan 23, 2025

#16724 installed spirv-tools on Linux docker containers and now some llvm-spirv tests are failing due to this (example: https://github.com/intel/llvm/actions/runs/12915358763/job/36017038536).
In this PR, we disable detection of spirv-tools LIT feature temporarily in CI to fix post-commit.

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock fixing CI failures, but llvm-spirv changes should either be upstreamed, or tracked in #7592 to remind us to revert them

.github/workflows/sycl-linux-build.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-build.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-windows-build.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-windows-build.yml Outdated Show resolved Hide resolved
llvm-spirv/test/lit.cfg.py Outdated Show resolved Hide resolved
llvm-spirv/test/lit.cfg.py Outdated Show resolved Hide resolved
llvm-spirv/test/lit.cfg.py Outdated Show resolved Hide resolved
llvm-spirv/test/lit.cfg.py Outdated Show resolved Hide resolved
llvm-spirv/test/lit.cfg.py Outdated Show resolved Hide resolved
@maarquitos14
Copy link
Contributor

I'm okay with merging this to fix post-commit.

About the root cause, the problem seems to be that the path for all spirv-tools binaries is not found:

llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find spirv-as in SPIRV_AS_PATH-NOTFOUND
llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find spirv-dis in SPIRV_AS_PATH-NOTFOUND
llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/subst.py:[12](https://github.com/intel/llvm/actions/runs/12918158681/job/36026109985#step:14:13)6: note: Did not find spirv-link in SPIRV_AS_PATH-NOTFOUND
llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find spirv-val in SPIRV_AS_PATH-NOTFOUND

I'm not sure why, I cannot reproduce locally. If you help me reproduce the issue, I can try and fix it.

Co-authored-by: Marcos Maronas <[email protected]>
@uditagarwal97 uditagarwal97 changed the title [CI] Temporarily disable tests requiring spriv-tools in CI [CI] Temporarily disable tests requiring spirv-tools in CI Jan 23, 2025
@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers I think we are good to merge this.

@sarnex sarnex merged commit f12546b into sycl Jan 23, 2025
22 of 30 checks passed
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/udit/llvm_spirv branch January 23, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants