Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Matrix][E2E] Remove REQUIRES: build-and-run-mode from Matrix tests #16787

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jan 27, 2025

As of #16725 tests that do not build for spir64 do not need to be marked as exceptions for split build/run with REQUIRES: build-and-run-mode, instead we can mark them as REQUIRES: target-<nvidia/amd>.

This patch replaces the REQUIRES: build-and-run-mode directives in Matrix tests with REQUIRES: target-amd or REQUIRES: target-nvidia.

@ayylol ayylol requested a review from a team as a code owner January 27, 2025 13:45
@ayylol
Copy link
Contributor Author

ayylol commented Jan 27, 2025

note for matrix reviewers: This was the initial motivation for moving tests into an "intel_matrix" folder in #16563, the rest of the tests will eventually need to be marked with REQUIRES: target-spir since they do not build for amd/nvidia triples. I didn't do it in this pr since it wont make a difference right now, because currently the split build/run is only enabled for spir triple.

@ayylol
Copy link
Contributor Author

ayylol commented Jan 28, 2025

@intel/llvm-gatekeepers this is ready to merge

@dm-vodopyanov dm-vodopyanov merged commit fee4449 into intel:sycl Jan 28, 2025
17 checks passed
@ayylol ayylol deleted the matrix-remove-build-and-run branch January 28, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants