Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt #398

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Update CMakeLists.txt #398

merged 2 commits into from
Feb 10, 2023

Conversation

haonanya
Copy link

@haonanya haonanya commented Feb 6, 2023

  1. Add additional link dependencies for NVPTX and AMDGPU
  2. Create stripped pdbs for Windows
  3. Remove windows_resource_file in windows

@haonanya1
Update CMakeLists.txt
f94e2d4 
1. Add additional link dependencies for NVPTX and AMDGPU
2. Create stripped pdbs for Windows
3. Remove windows_resource_file in windows
@haonanya haonanya marked this pull request as draft February 6, 2023 08:49
@haonanya haonanya requested review from cdai2 and wenju-he February 6, 2023 13:21
@haonanya haonanya marked this pull request as ready for review February 6, 2023 13:23
wenju-he
wenju-he reviewed Feb 7, 2023
View reviewed changes
common_clang.cpp Outdated
@@ -319,7 +319,7 @@ Compile(const char *pszProgramSource, const char **pInputHeaders,
if (pBinaryResult) {
*pBinaryResult = nullptr;
}
assert(!"Failed to read just compiled LLVM IR!");
assert(0 && "Failed to read just compiled LLVM IR!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(0 && "Failed to read just compiled LLVM IR!");
assert(false && "Failed to read just compiled LLVM IR!");

wenju-he
wenju-he reviewed Feb 7, 2023
View reviewed changes
CMakeLists.txt
@@ -85,6 +85,7 @@ if (NOT WIN32)
endif()

use_rtti(FALSE)
use_eh(TRUE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need to enable exception on in opencl-clang tests

wenju-he
wenju-he approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please consider removing use_eh from library files and investigating if we can change add_library back to add_llvm_library. I suggest to create issues to track these two tasks.

@haonanya
Copy link
Author

haonanya commented Feb 8, 2023

LGTM. Please consider removing use_eh from library files and investigating if we can change add_library back to add_llvm_library. I suggest to create issues to track these two tasks.

Thanks. File #400 and #401 to track.

@haonanya haonanya merged commit 743bd15 into intel:main Feb 10, 2023
@haonanya haonanya deleted the unify-src-code branch February 28, 2023 05:39
@wenju-he wenju-he mentioned this pull request Apr 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenju-he wenju-he wenju-he approved these changes

@cdai2 cdai2 Awaiting requested review from cdai2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haonanya @wenju-he @haonanya1