-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 2.0 and 2024.0 compatibility #92
Conversation
openvino-sys crate builds and tests pass with api 2.0 with some caveats update openvino api to 2.0, classify-mobilenet working test remove comments and outdated files cleanup, change methods in impl based on parameters alexnet test fix samples/tests, start tests for tensor add tests tests continue fix version test, add tests to lib update and add docs Add Result<>, fix tests cargo fmt fix warnings in request.rs of unused imports delete vscode file change to accept variadic args with '...' link macro format format link macro
Merge from API 2.0 fork
Minor changes.
I reverted the result assertion in the
The second value in the |
@@ -1,4 +1,4 @@ | |||
[submodule "crates/upstream"] | |||
path = crates/openvino-sys/upstream | |||
url = https://github.com/openvinotoolkit/openvino | |||
depth = 1 | |||
shallow = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://git-scm.com/docs/gitmodules#Documentation/gitmodules.txt-submoduleltnamegtshallow
It's possible that depth = 1
was working as expected, but it's not a documented property in .gitmodules
.
Also, on my AMD laptop, the
|
Add more enums.
Improve enum handling for ElementType.
This reverts commit ed1d59a.
This reverts commit c1a3b68.
Yes, I plan on rebasing this PR at some point. My fork is working for my use case and I'm very busy at the moment, so it will be a while before I can work on this again. |
Hi @BTOdell, we're looking forward to the next release of the openvino crate soon, and we were hoping some of the improvements you've made here would be incorporated in that release. Do you want me to cherry-pick some of the changes if possible from this PR, so that we would have a release candidate ready? |
Yeah, feel free to cherry-pick. In addition to the items mentioned in the description, I added quite a few functions that were not originally ported in your PR:
I was also having an issue calling variadic C functions due to a bug in the |
Hi @BTOdell , I've started cherry picking some of the commits, and for few others I need to manually change some code so as to not cause merge conflicts. If you can let me know your email associated with github, I can add you as co-author (cherry-pick did this automatically). This can even be your |
Looking at this now, it seems like @rahulchaphalkar cherry-picked most of this into separate PRs that are now merged and published as the |
This PR is based on #91 but with additional changes, bug fixes, and feature improvements.
Changes
upstream
to version2024.0.0
.Implementinfer_async
function. May need help making sure the unsafe callback code is sound and with the custom Future implementation needed connect the OpenVINO infer request callback to Rust's async syntax.