Update and add enums #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
reviewed
May 13, 2024
crates/openvino/src/element_type.rs
Outdated
| impl From<u32> for ElementType { | ||
| fn from(value: u32) -> Self { | ||
| if value > LARGEST_VARIANT { | ||
| return ElementType::Undefined; |
There was a problem hiding this comment.
This might be better as a TryFrom implementation: if the user passes in a u32 value that doesn't line up, we can then return an error instead of silently converting it into ElementType::Undefined.
There was a problem hiding this comment.
Alternately, do we need this "from u32" functionality?
There was a problem hiding this comment.
I think From was needed before this commit. The into() made sense when this was let mut element_type = 0, but I have it initialized as ElementType::Undefined.
So probably can do without From implemented.
crates/openvino/src/element_type.rs
Outdated
| return ElementType::Undefined; | ||
| } | ||
| // SAFETY: ElementType has repr(u32) and the bounds have been checked | ||
| unsafe { std::mem::transmute(value) } |
There was a problem hiding this comment.
transmute is pretty unsafe; is there no way to do this by casting?
rahulchaphalkar
force-pushed
the
add-enums
branch
from
6c1be4d to
13bbeac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element_type, addedFromtraitresize_algorithmenum