safestringlib: safeclib/strpbrk_s.c: check string boundaries

Signed-off-by: Tomas Winkler <[email protected]>
intel · Jan 23, 2024 · 4ee034f · 4ee034f
1 parent b0cc18c
commit 4ee034f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/safeclib/strpbrk_s.c b/safeclib/strpbrk_s.c
@@ -67,7 +67,6 @@ strpbrk_s (char *dest, rsize_t dmax,
            char *src,  rsize_t slen, char **first)
 {
     char *ps;
-    rsize_t len;
 
     if (first == NULL) {
         invoke_safe_str_constraint_handler("strpbrk_s: count is null",
@@ -117,10 +116,9 @@ strpbrk_s (char *dest, rsize_t dmax,
      */
     while (dmax && *dest) {
 
+        rsize_t len = slen;
         ps = src;
-        len = slen;
-        while (*ps) {
-
+        while (*ps && len > 0) {
             /* check for a match with the substring */
             if (*dest == *ps) {
                 *first = dest;