-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add profile test #1333
[CI] Add profile test #1333
Conversation
ca0bf59
to
05a0290
Compare
4f2ceaa
to
19de845
Compare
19de845
to
d006cf0
Compare
@@ -0,0 +1,10 @@ | |||
import torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to move those profiling test files into test/profiling
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean put those in '.github/scripts/test/profiling/'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, together with others tests in https://github.com/intel/torch-xpu-ops/tree/main/test directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok~
.github/workflows/_linux_profile.yml
Outdated
@@ -0,0 +1,219 @@ | |||
name: Linux Profile Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add one more step to tun profiling test in _linux_ut.yml
directly, and this step only triggered with rolling driver ut test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean keep _linux_profile.yml and add another step to run profiling test in _linux_ut.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to keep this new workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok~, will design the workflow.
8b862e0
to
c95de6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
.github/workflows/_linux_ut.yml
Outdated
@@ -252,6 +252,30 @@ jobs: | |||
timeout 10000 python run_distributed.py 2>${{ github.workspace }}/ut_log/xpu_distributed/xpu_distributed_test_error.log | tee ${{ github.workspace }}/ut_log/xpu_distributed/xpu_distributed_test.log | |||
cd ${{ github.workspace }} | |||
sudo cp ptrace_scope.bk /proc/sys/kernel/yama/ptrace_scope | |||
- name: Run Torch XPU Profile UT | |||
if: ${{ inputs.driver == 'rolling' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a new UT scope name for it in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss the scope name. Will add it and test my branch
And please launch a on-demand test on rolling node base on this PR branch |
@chuanqi129 On-demand test results: https://github.com/intel/torch-xpu-ops/actions/runs/13495003215 |
Add profile test for profiling feature test