Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add profile test #1333

Merged
merged 22 commits into from
Feb 25, 2025
Merged

[CI] Add profile test #1333

merged 22 commits into from
Feb 25, 2025

Conversation

RUIJIEZHONG66166
Copy link
Contributor

Add profile test for profiling feature test

@RUIJIEZHONG66166 RUIJIEZHONG66166 force-pushed the ruijie/add_profile_test branch 2 times, most recently from ca0bf59 to 05a0290 Compare February 10, 2025 07:33
@@ -0,0 +1,10 @@
import torch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to move those profiling test files into test/profiling folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean put those in '.github/scripts/test/profiling/'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, together with others tests in https://github.com/intel/torch-xpu-ops/tree/main/test directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok~

@@ -0,0 +1,219 @@
name: Linux Profile Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add one more step to tun profiling test in _linux_ut.yml directly, and this step only triggered with rolling driver ut test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean keep _linux_profile.yml and add another step to run profiling test in _linux_ut.yml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to keep this new workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok~, will design the workflow.

Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@@ -252,6 +252,30 @@ jobs:
timeout 10000 python run_distributed.py 2>${{ github.workspace }}/ut_log/xpu_distributed/xpu_distributed_test_error.log | tee ${{ github.workspace }}/ut_log/xpu_distributed/xpu_distributed_test.log
cd ${{ github.workspace }}
sudo cp ptrace_scope.bk /proc/sys/kernel/yama/ptrace_scope
- name: Run Torch XPU Profile UT
if: ${{ inputs.driver == 'rolling' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a new UT scope name for it in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss the scope name. Will add it and test my branch

@chuanqi129
Copy link
Contributor

And please launch a on-demand test on rolling node base on this PR branch

@RUIJIEZHONG66166
Copy link
Contributor Author

And please launch a on-demand test on rolling node base on this PR branch

@chuanqi129 On-demand test results: https://github.com/intel/torch-xpu-ops/actions/runs/13495003215
Could you please double check it? I will merge if its ok after CI pass.

@RUIJIEZHONG66166 RUIJIEZHONG66166 added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit db45479 Feb 25, 2025
15 of 16 checks passed
@RUIJIEZHONG66166 RUIJIEZHONG66166 deleted the ruijie/add_profile_test branch February 25, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants