-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LayerNorm with Welford online algorithm #1374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add test case |
guangyey
reviewed
Feb 18, 2025
guangyey
reviewed
Feb 18, 2025
guangyey
reviewed
Feb 18, 2025
Co-authored-by: Yu, Guangye <[email protected]>
Build fails against latest pytorch with:
Please, fix. I would like to verify PR against pytorch/pytorch#141642. |
@min-jean-cho Please resolve case failure |
dvrogozh
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me to resolve pytorch/pytorch#141642. Please, update PR title (drop "[WIP][Test]") if ready.
xytintel
reviewed
Feb 21, 2025
xytintel
reviewed
Feb 21, 2025
xytintel
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welford online algorithm improves the numerical stability of variance computation compared to naive or two-pass algorithm.
Simple test case:
Output now (welford):
Output before (two-pass):