Server communication #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some breaking changes since i last tested it, so no merge yet. |
… it in ServerRequests
…don package from the AddonInformationManager and build information from file-system instead of maintaining lists
…ode from AddonManager into it
… the scattered update functionality in one place and provide an simple interface
LeanderK
force-pushed
the
server_communication
branch
from
e069319 to
d2641b0
Compare
|
Ok not bad overall, but you do know that there was an izou.properties file before that was supposed to be the config file for izou (that is why you sometimes got the error, not fully configuered yet, izou is quitting). So do you wanna remove that? Both seem redundant. |
|
it is mostly done |
|
@jundl77 i think this is ready to merge now |
|
Did you remove the izou properties stuff? |
|
i don't have Izou-properties in my repo...i think. Where is it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds full support for the upcoming cloud-infrastructure
Motivation:
With this pull request Izou is able to respond to request from the server and automatically download/update itself and the apps. The related issue is #19.
It introduces 3 new packages,
server,config,org.intellimate.server.protoand adds needed functionality to existing ones:package
server:CommunicationManager: this class servers as the interface for other packages and provides a small API to deal with the server-communication.DelegatingInputstream: A InputStream that has does nothing on close(), it is used for as the InputStream for the Request since we don't want anybody to close our socket connection after reading from the inputRequest: The Interface for the Requests coming from the server to Izou (maybe originating from an http-connection to the server). This interface is AddonAccessibleRequestImpl: The implementation for the Request interface.RequestHandler: this class is responsible for the handling of the Requests from the server. It answers the request intended for izou (get/patch of state, get/patch/put of AddOns etc.) and delegates to the AddOns if requested.Response: the interface for the Response to an Request from the server. This interface is AddonAccessible.ResponseImpl: The Implementation of the Response interface used for the Responses originating from izou and not the addonsServerRequestHandler: The Functional Interface used in ServerRequest to dynamically bind handlersServerRequests: Here the actual communication with the Server happens. Requests from the Server get deserialised and responses serialised. It also contains various methods for normal http-request to the server used in other packages.SSLCertificateHelper: This class is needed because java does not trust out lets-encrypt certificate yet, it alters the keystone and adds the needed certificate on startuppackage
org.intellimate.server.proto:This class contains the compiled prototbuf-files which specify the communication with the server
package
config:AddOn: the representation of AddOns for the internal-config fileConfig: the representation of the Config file. This file should be created/edited by the user and contains a few entries to fully configure izou (for example the refresh-token).InternalConfig: the internal configuration used to persist the selected Addons and the state for restartVersion: a simple version class used for interacting with the addons in the internal-config filepackage
addon:added:
AddOnFileManager: this class is has methods used to get information about the addOn-files (getInstalled, getScheduledToInstall, getScheduledToDelete etc.)SynchronizationManager: this class is responsible for the synchronisation of the AddOns. It takes the selected Addons, then builds the dependency tree and compares that to the installed addons. If there is a new one available it downloads the add-on or creates an entry for future deletion. It also copies the new addons/delete unnecessary ones on startup.changed:
AddOnManager: integrated the functionality from the SynchronizationManager and exposes a clean interface for the new functionality for other packagespackage
identification:AddOnInformationImpl: improved code qualityAddOnInformationManager: integrated information obtained from the internal-config file into the AddOnInformationManagerIdentificationManagerImpl: improved code qualitypackage
main:added:
IzouSynchronization: contains the code to query & download new Izou versionsUpdateManager: used to bundle the necessary function calls for the update-functionality in one place and provide one clean interfacechanged:
Main: updated the startup-procedure to incorporate the new sub-systemspackage
system:added:
ServerInformation: exposes information about the communication with the server to the addonschanged:
Context: integrated the new interface ServerInformationFileSystemManager: adds the new newLib directory where the new versions for the addons get downloaded toContextImplementation: adapted to the changes specified abovenon-java changes:
added needed certificates to the resources which are needed to convince java that letsencrypt-certificates are safe.
There are 2 config-files:
izou.ymlandinternal.yml. Onlyizou.ymlis expected to be present on startup and should be edited by the user.The maven pom was updated, some new dependencies were added.