Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add performance script to PR jobs #3274

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Conversation

BlairCurrey
Copy link
Contributor

@BlairCurrey BlairCurrey commented Feb 5, 2025

Changes proposed in this pull request

  • Decouples testenv from integration tests such that it can be re-used for performance tests in CI
    • MockASE handles seeding and hosting integration endpoints required for rafiki to properly function (rates, webhooks). This is located in the integration tests in main so I moved it out for re-use when running performance tests.
    • Performance tests in main run against our localenvironment. Since we're already running this test environment in CI (and since it's a intended for testing) I changed the performance tests to target the test environment

Context

fixes: #3240

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

- currently requires running tests to setup db
(waiting to avoid actually running tests and spinning down tests/env)
- loses ability to run k6 against rafiki w/ telemetry
- in preparation for switching performance test
to target testenv
- ensured integration tests pass
- supports reuse in setup script for performance tests
which will allow running performance test against testenv
- also bumps graphql pacakge version across monorepo.
added to test-lib which caused some type errors
in backend and auth due to a version mismatch
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. labels Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit f27d966
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67a66ed936843000085761bd

@github-actions github-actions bot added the type: source Changes business logic label Feb 5, 2025
@github-actions github-actions bot added the type: ci Changes to the CI label Feb 7, 2025
@BlairCurrey BlairCurrey changed the title Bc/3240/performance ci ci: add performance script to PR jobs Feb 7, 2025
@github-actions github-actions bot added the pkg: auth Changes in the GNAP auth package. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. type: ci Changes to the CI type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add performance monitoring for each PR
1 participant