Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developing gene-pathway visualisation #1

Merged
merged 51 commits into from
Jul 15, 2020

Conversation

Sakshisrivastava413
Copy link
Member

@Sakshisrivastava413 Sakshisrivastava413 commented May 20, 2020

Todo:

  • Parse data in the format required by graph lib (nodes and edges)
  • Render and test graph UI
  • Add tooltip on node hover to show additional information
  • Add color indications - child with multiple parents will have multiple colors
  • Setup pathway filter
  • Add test using Jest
  • Support for tool API version 2

Used cose-blikent extension for node layout placement. Using DOM methods to show tooltip on node hover. Created a constant file containing an array of colors and picking node color from there which will maintain it's after filtering also. Added select and deselect option in pathway filter panel for ease in filtering. Also, made it compatible for single as well multiple entity gene interactions.

Enhancements:

  • Changed shape of the parent node to barrel - rounded square and child node to ellipse to distinguish gene and its pathway easily
  • Removed labels from all pathway nodes
  • Created a toggle button to show only the shared pathway nodes when on and all nodes when switched off
  • Commented code

@asherpasha
Copy link

Hi Sakshi,
Thank you for getting started on this. I have tested it on my computer, and it works. I think we should merge the pull request.
See:
Screenshot at 2020-05-20 12-30-26

@Sakshisrivastava413
Copy link
Member Author

Thanks @asherpasha for having a look at this. :) Let me first complete the checkpoints then it will ready to get merged.

@Sakshisrivastava413 Sakshisrivastava413 changed the title [WIP] developing gene-pathway visualisation developing gene-pathway visualisation May 27, 2020
Copy link

@asherpasha asherpasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@heralden heralden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great like the other network graphs! 🎉

I added some comments on things which should be quick to fix.

The state could be cleaned up similarly to intermine/bluegenes-interaction-network#1, but since it already works like it is, it isn't really high priority (it's more of an exercise if you want to improve your React skills). I can create an issue for this later, along with some other stuff which we can solve in separate PRs:

  • Handling of no results (currently it seems to show Loading forever)
  • Disable shared nodes on load if none are present (instead of an empty screen)
    • Could also apply when filters are changed such that there are no more shared nodes, but I think we should confirm this with Rachel first

@Sakshisrivastava413
Copy link
Member Author

@uosl The points look relevant. Thanks for reviewing the code.

Copy link
Member

@heralden heralden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 👍

@heralden heralden merged commit 4c094fe into intermine:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants