-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
developing gene-pathway visualisation #1
Conversation
…o purpose to get the required data
Thanks @asherpasha for having a look at this. :) Let me first complete the checkpoints then it will ready to get merged. |
…cked state instead of using splice func, also having checked boxes count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great like the other network graphs! 🎉
I added some comments on things which should be quick to fix.
The state could be cleaned up similarly to intermine/bluegenes-interaction-network#1, but since it already works like it is, it isn't really high priority (it's more of an exercise if you want to improve your React skills). I can create an issue for this later, along with some other stuff which we can solve in separate PRs:
- Handling of no results (currently it seems to show Loading forever)
- Disable shared nodes on load if none are present (instead of an empty screen)
- Could also apply when filters are changed such that there are no more shared nodes, but I think we should confirm this with Rachel first
@uosl The points look relevant. Thanks for reviewing the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! 👍
Todo:
Used cose-blikent extension for node layout placement. Using DOM methods to show tooltip on node hover. Created a constant file containing an array of colors and picking node color from there which will maintain it's after filtering also. Added select and deselect option in pathway filter panel for ease in filtering. Also, made it compatible for single as well multiple entity gene interactions.
Enhancements:
barrel - rounded square
and child node toellipse
to distinguish gene and its pathway easily