chore: use ruff for formatting #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few minor changes here compared to black; it flagged unnecessary string concatenations, and has slightly different opinions on line length.
galgeek
reviewed
Feb 25, 2025
| @@ -1,7 +1,7 @@ | |||
| .PHONY: format | |||
| format: | |||
| venv/bin/black -t py35 -t py36 -t py37 -t py38 -t py39 -t py310 -t py311 -t py312 . | |||
| venv/bin/ruff format --target-version py37 . | |||
There was a problem hiding this comment.
Python 3.7 is the earliest version we can target, per
https://docs.astral.sh/ruff/settings/#target-version
There was a problem hiding this comment.
I should have mentioned, by the way, that unlike black it doesn't want you to specify every version you support - just the lowest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a discussion about this with Alex; we thought it might be a good idea to try out
rufffor formatting rather thanblack. Seems to be working well so far in local testing.There are a few minor changes here compared to
black; it flagged unnecessary string concatenations thatblackdidn't care about, and has slightly different opinions on line length.