Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability Process Tracking #36

Merged
merged 26 commits into from
Jul 5, 2024
Merged

Interoperability Process Tracking #36

merged 26 commits into from
Jul 5, 2024

Conversation

isc-cge
Copy link
Collaborator

@isc-cge isc-cge commented Jul 2, 2024

Created an extra option for monitoring coverage by the current job as well as all interoperability processes.

Callable by setting tCoverageParams("ProcessIDs") = $ListBuild("Interop") and using RunTest() or by passing in $ListBuild("Interop") as the pPIDList parameter in RunAllTests()

Using "Interoperability" in place of $ListBuild("Interop") works as well.

Fixes #14

isc-cge added 23 commits June 20, 2024 14:13
…bility processes after the production starts in %UnitTest.TestProduction test cases
…bles, and added namespace to the query for processes
…bility too, tested that it still works on Profiler and using RunAllTests
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor comments.

Please also update CHANGELOG.md with a line on this in the "Added" section, referencing the issue number at the end - i.e.:

cls/TestCoverage/Manager.cls Outdated Show resolved Hide resolved
cls/TestCoverage/Manager.cls Outdated Show resolved Hide resolved
cls/TestCoverage/Manager.cls Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.71%. Comparing base (0c2ff29) to head (ccca030).
Report is 3 commits behind head on master.

Files Patch % Lines
cls/TestCoverage/Manager.cls 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   38.98%   38.71%   -0.28%     
==========================================
  Files          14       14              
  Lines        1244     1258      +14     
==========================================
+ Hits          485      487       +2     
- Misses        759      771      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isc-tleavitt
isc-tleavitt previously approved these changes Jul 5, 2024
@isc-tleavitt
Copy link
Collaborator

Last thing - need to bump module.xml version to 3.2.0

@isc-tleavitt isc-tleavitt merged commit 7cc4f4b into master Jul 5, 2024
3 checks passed
@isc-tleavitt isc-tleavitt deleted the InteropProcesses branch July 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do a better job collecting coverage on all processes
2 participants