Move static attributes from GlobalConfig to controller params #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 90.16% 85.10% -5.06%
==========================================
Files 18 17 -1
Lines 4492 4598 +106
==========================================
- Hits 4050 3913 -137
- Misses 442 685 +243 ☔ View full report in Codecov by Sentry. |
laracroft37
force-pushed
the
controller-settings
branch
12 times, most recently
from
638f299 to
f835d44
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pevogam
requested changes
Nov 29, 2024
laracroft37
force-pushed
the
controller-settings
branch
from
79c166d to
b0529e3
Compare
pevogam
reviewed
Nov 29, 2024
laracroft37
force-pushed
the
controller-settings
branch
4 times, most recently
from
c589a95 to
ce53b4d
Compare
pevogam
approved these changes
Nov 29, 2024
laracroft37
force-pushed
the
controller-settings
branch
from
ce53b4d to
1db8778
Compare
Update key-value pairs in the params dictionary for a generic controller. We can now set click timeout and other settings for each separate controller instance. Localize delay_before_keys to display controllers moving it away from the region class as it is still relate to key typing configuration. rename toggle_delay to mouse_toggle_delay
laracroft37
force-pushed
the
controller-settings
branch
from
dd0c447 to
0e823d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update key-value pairs in the params dictionary for a generic controller. We can now set click timeout and other settings for each separate controller instance.