Provide internal unfind method to emulate inverse find #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is needed to separate internal method calls within the region class since certain public methods like `wait` and the previously unfind emulating `wait_vanish` could be overridden while `find` and the resulting `_unfind` are typically not to preserve behaviors from all internal calls by other public region methods. For instance to better illustrate this - consider a case where we would like to catch `FindError` and `NotFindError` exceptions and convert them to test failures or other specialized exceptions. If one overrides `wait` and `wait_vanish` then `click_vanish` or e.g. `press_expect` will not catch the right exception types and guibot will not retry its human-like UI control attempts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 85.09% 85.10%
=======================================
Files 17 17
Lines 4637 4639 +2
=======================================
+ Hits 3946 3948 +2
Misses 691 691 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is needed to separate internal method calls within the region class since certain public methods like
waitand the previously unfind emulatingwait_vanishcould be overridden whilefindand the resulting_unfindare typically not to preserve behaviors from all internal calls by other public region methods.For instance to better illustrate this - consider a case where we would like to catch
FindErrorandNotFindErrorexceptions and convert them to test failures or other specialized exceptions. If one overrideswaitandwait_vanishthenclick_vanishor e.g.press_expectwill not catch the right exception types and guibot will not retry its human-like UI control attempts.