Merge pull request #4 from intuiface/hotfix/InvalidImageSource

revert: avoid creating an empty image if loading fail, use imagePlaceholder instead
intuiface · Feb 29, 2024 · 11fd7c2 · 11fd7c2
2 parents de158fd + 6a64bb7
commit 11fd7c2
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## [1.11.18](https://github.com/bubkoo/html-to-image/compare/v1.11.17...v1.11.18) (2024-02-28)
+
+### Bug Fixes
+
+* revert all commits which use an empty image as the option imagePlaceholder can be used
+
 ## [1.11.17](https://github.com/bubkoo/html-to-image/compare/v1.11.16...v1.11.17) (2024-02-26)
 
 ### Bug Fixes

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@intuiface/html-to-image",
-  "version": "1.11.17",
+  "version": "1.11.18",
   "description": "Generates an image from a DOM node using HTML5 canvas and SVG. This is a fork from antoher fork Repo (2knu/html-to-image) from the original Repo (bubkoo/html-to-image)",
   "main": "lib/index.js",
   "module": "es/index.js",

diff --git a/src/clone-node.ts b/src/clone-node.ts
@@ -25,12 +25,6 @@ async function cloneVideoElement(video: HTMLVideoElement, options: Options) {
     const dataURL = canvas.toDataURL()
     return createImage(dataURL)
   }
-  if (video.poster == null || video.poster === '') {
-    // create an image with the tyniest source found
-    return createImage(
-      'data:image/png;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==',
-    )
-  }
 
   const poster = video.poster
   const contentType = getMimeType(poster)

diff --git a/src/embed-images.ts b/src/embed-images.ts
@@ -50,11 +50,7 @@ async function embedImageNode<T extends HTMLElement | SVGImageElement>(
     return
   }
 
-  let url = isImageElement ? clonedNode.src : clonedNode.href.baseVal
-  if (!url || url === '') {
-    url =
-      'data:image/png;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=='
-  }
+  const url = isImageElement ? clonedNode.src : clonedNode.href.baseVal
 
   const dataURL = await resourceToDataURL(url, getMimeType(url), options)
   await new Promise((resolve, reject) => {