Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webcam not allowed and image is empty #2

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mikaelkurek
Copy link

This PR fixes an issue with the Camera if there is no authorization to access it.

Description

When the authorization for the Camera is forbidden, a video tag is detected but the lib crashes. To avoid this crash, I create an empty image.

Motivation and Context

Fix an issue when the camera is not allowed or when a video source is empty and there is no poster.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@nicolas-daures nicolas-daures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impec

@mikaelkurek mikaelkurek merged commit 24b1ab6 into master Feb 16, 2024
3 checks passed
@mikaelkurek mikaelkurek deleted the hotfix/EmptyWebCamImage branch February 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants