config: disables sqlalchemy pane of flask-debugtoolbar for mysql #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roksys
force-pushed
the
mysql-debugtoolbar-fix
branch
from
58eeca1
to
45c4ef8
Compare
roksys
force-pushed
the
mysql-debugtoolbar-fix
branch
from
45c4ef8
to
970ebfd
Compare
kpsherva
reviewed
Nov 13, 2019
| @@ -113,6 +113,20 @@ def _(x): | |||
| {%- elif cookiecutter.database == 'mysql'%} | |||
| SQLALCHEMY_DATABASE_URI = \ | |||
| 'mysql+pymysql://{{cookiecutter.project_shortname}}:{{cookiecutter.project_shortname}}@localhost/{{cookiecutter.project_shortname}}' | |||
|
|
|||
| # Disable Flask-DebugToolbar SQLAlchemy pane | |||
There was a problem hiding this comment.
I would disable everything here, not only the SQLAlchemy one, it will be more obvious for the developer that the toolbar is not working as a whole (it is less obvious that only the sqlalchemy part is missing) and it will point them to look at the config.
Also please add into the comment here something like Disable Flask-DebugToolbar only for mysql database configuration due to the issue so it is clear that this was added to the config because of the database type choice
roksys
force-pushed
the
mysql-debugtoolbar-fix
branch
from
970ebfd
to
d521b3c
Compare
* sqlalchemy pane cannot handle UUID in bytes format pallets-eco/flask-debugtoolbar#112 Closes inveniosoftware#184
kpsherva
force-pushed
the
mysql-debugtoolbar-fix
branch
from
d521b3c
to
8130f27
Compare
kpsherva
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlalchemy pane cannot handle UUID in bytes format
UUID support in URLs pallets-eco/flask-debugtoolbar#112
Closes MySQL not working probably #184