global: add class based registry to extend idutils schemes #106
Conversation
zzacharo
force-pushed
the
add-class-registry
branch
from
bcc4b70 to
34c02e9
Compare
| @@ -37,7 +37,6 @@ install_requires = | |||
|
|
|||
| [options.extras_require] | |||
| tests = | |||
| invenio-app>=1.4.0 | |||
| pytest-black-ng>=0.4.0 | |||
| pytest-cache>=1.0 | |||
| pytest-runner>=2.6.2 | |||
There was a problem hiding this comment.
should the section [options.entry_points] be removed?
| ("swh", validators.is_swh), | ||
| ("viaf", validators.is_viaf), | ||
| ] | ||
| IDUTILS_PID_SCHEMES = _IDUTILS_PID_SCHEMES |
There was a problem hiding this comment.
Kept for backwards compatibility when importing.
| ), | ||
| ("pmid", ["viaf"]), | ||
| ] | ||
| IDUTILS_SCHEME_FILTER = _IDUTILS_SCHEME_FILTER |
There was a problem hiding this comment.
Kept for backwards compatibility when importing.
There was a problem hiding this comment.
I've tested and this doesn't break my usage. It would be useful to have some documentation on how the scheme extension works. This is one repository where maybe readthedocs would be a good place, just in https://github.com/inveniosoftware/idutils/blob/master/docs/index.rst. It will need #107 merged at a minimum to render.
Hey, thanks for testing it! I have added some documentation in https://github.com/inveniosoftware/idutils/blob/master/idutils/__init__.py#L19 but I am happy to add it also as part of the readthedocs too. |
zzacharo
force-pushed
the
add-class-registry
branch
3 times, most recently
from
3643570 to
5cbac53
Compare
zzacharo
force-pushed
the
add-class-registry
branch
from
5cbac53 to
90b42b9
Compare
closes #105