-
-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove django-allauth-2fa, dj-rest-auth and django-user-sessions #6293
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…matmair/issue6281
…matmair/issue6281
This is done as far as possible right now; I am waiting on upstream to merge a few PRs so that this can get merged. |
…matmair/issue6281
Upstream has merged what we need; this can be released after 0.65.4 is released; |
Do you mean upstream for django-allauth? |
@SchrodingersGat yes |
…matmair/issue6281
@matmair I indend to get to this soon to review and test |
…matmair/issue6281
…matmair/issue6281
…matmair/issue6281
This PR remove django-allauth-2fa and replaces it with the inline functions of django-allauth. This reduces the dependency footprint and eliminates a bunch of custom creations.
Update: Most of the planned things we would be interested in are now implemented and the scope shifted a bit - it makes sense to just ripp all auth extensions out and use only allauths built-in things. We have a lot of grown auth-adjacent code that can probably be removed/rewritten.
Related Issues
TODO
Coverage
This relies on several upstream PRs: