Bug fix for label printing with plugin on CUI #7324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Missed edge case in recent refactor
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7324 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 1049 1049
Lines 46031 46031
Branches 1386 1386
=======================================
Hits 38569 38569
Misses 7101 7101
Partials 361 361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martonmiklos
pushed a commit
to martonmiklos/InvenTree
that referenced
this pull request
Jun 24, 2024
* Bug fix for label printing with plugin on CUI - Missed edge case in recent refactor * Fix typo * Support non-pk fields * fix a number of typos * js fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Selecting the label priting plugin in the dialog causes some rendering issues with the form. Need to look into this further before it is in a good state to merge.