Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(strongly-typed): inject decorator type #114

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat(strongly-typed): inject decorator type #114

merged 1 commit into from
Nov 20, 2024

Conversation

alecgibson
Copy link
Contributor

This change builds on the work of the TypedContainer by adding type definitions for a strongly-typed inject decorator.

@alecgibson alecgibson mentioned this pull request Nov 20, 2024
Merged
notaphplover
notaphplover requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great! We just need to handle async mapped types properly and add a test case for it.

packages/container/libraries/strongly-typed/src/inject.ts Outdated Show resolved Hide resolved
packages/container/libraries/strongly-typed/src/inject.spec.ts Show resolved Hide resolved
packages/container/libraries/strongly-typed/README.md Show resolved Hide resolved
@alecgibson
feat(strongly-typed): inject decorator type
f47c304 
This change builds on the work of the [`TypedContainer`][1] by adding
type definitions for a strongly-typed `inject` decorator.

[1]: inversify#59
notaphplover
notaphplover approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@notaphplover notaphplover merged commit 3f16c5b into inversify:main Nov 20, 2024
3 checks passed
@alecgibson alecgibson deleted the strong-inject branch November 20, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notaphplover notaphplover notaphplover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecgibson @notaphplover