-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option that allows to include commit bodies in changelog #606
Conversation
Example changelog produced with
|
Just a heads up that with this activated one is unfortunately going to run into the max changelog size very quickly on pub.dev so might be worth mentioning that in the docs, otherwise I think that it looks good! Would be nice if it would be configurable to only take the commit body on breaking changes, but that's probably outside of the scope for this PR of course. |
I didn't know there is such a limit 😮 |
Done |
256KB - dart-lang/pub-dev#6012
Amazing! That will be super helpful for Flame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good!
Some docs would be good though
Let's follow up with a docs PR, @lesnitsky lmk if you want me to do it. This is published in 3.3.0 |
Description
This PR introduces a new version command option:
This might be useful for PRs with breaking changes (migration guides could be added to changelog from commit boides)
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore