Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Directory.Build.props and Invocative.Neko.Framework.csproj #2

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Update Directory.Build.props and Invocative.Neko.Framework.csproj #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfcbce2
Update Directory.Build.props and Invocative.Neko.Framework.csproj
0xF6 Jan 13, 2024
4ba705b
Update src/core/Invocative.Neko.Framework.csproj
0xF6 Jan 13, 2024
f8483e0
Update Directory.Build.props
0xF6 Jan 13, 2024
e5b6d14
fixes icon
0xF6 Jan 13, 2024
7a03ba6
Merge branch 'rc3' of https://github.com/invocative/neko.framework in…
0xF6 Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<Version>1.0-rc.2</Version>
<Version>1.0-rc.3</Version>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
<Deterministic>true</Deterministic>
<Features>strict</Features>
Expand All @@ -13,8 +13,20 @@
<Copyright>(C) 2024 Invocative Studio</Copyright>
<IncludeSymbols>True</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<PackageProjectUrl>https://github.com/invocative/neko.framework</PackageProjectUrl>
<RepositoryType>git</RepositoryType>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageIcon>icon.png</PackageIcon>


</PropertyGroup>
<ItemGroup>
<None Include="..\..\..\icon.png">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
0xF6 marked this conversation as resolved.
Show resolved Hide resolved
</None>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon.png file exists in the root of the repository, which confirms that the relative path specified in the Directory.Build.props file is incorrect, as it points three directories up from the expected location. The path should be adjusted to correctly reference the icon.png file from the location of the Directory.Build.props file.

Analysis chain

The relative path for icon.png seems to go three directories up from the property file's location. Please verify that the path is correct and that the icon file exists at the specified location.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the existence of the icon.png at the specified path.
fd icon.png --exec test -f {}

Length of output: 69

Script:

#!/bin/bash
# The previous script failed because it used 'test -f' which is not a command that can be executed by fd's --exec flag.
# Instead, we will use 'ls' to list the file if it exists.
fd icon.png --exec ls {}

Length of output: 39

</ItemGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'">
<LibNetSharedVersion>6.0.*</LibNetSharedVersion>
Expand Down
Binary file added icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 8 additions & 3 deletions src/core/Invocative.Neko.Framework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@
<Nullable>enable</Nullable>

<Title>Neko Core Abstractions Library</Title>

<Description>Core library for neko framework</Description>
</PropertyGroup>
<ItemGroup>
<None Include="..\..\icon.png">
<Pack>True</Pack>
<PackagePath>/</PackagePath>
</None>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Flurl.Http" Version="4.0.1" />
<PackageReference Include="JetBrains.Annotations" Version="2023.3.0" />
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>
<ItemGroup>
<Folder Include="Features\" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/features/HangFire/HangFireFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ public override void BeforeRun(WebApplication webBuilder)
[PublicAPI]
public static class HangFireFeatureIAppBuilder
{
public static IAppBuilder WebSockets(this IAppBuilder builder, Action<IGlobalConfiguration, IAppCreationContext> config)
public static IAppBuilder HangFire(this IAppBuilder builder, Action<IGlobalConfiguration, IAppCreationContext> config)
=> builder.InjectFeature(x => new HangFireFeature(config, x));
}
Loading