Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): support videos modal #7300

Merged
merged 4 commits into from
Nov 19, 2024
Merged

feat(ui): support videos modal #7300

merged 4 commits into from
Nov 19, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Nov 8, 2024 •
edited
Loading

Summary

Add a modal w/ links to our support videos on youtube.

QA Instructions

Screen.Recording.2024-11-08.at.6.27.42.pm.mov

Checklist

  • The PR has a short but descriptive title, suitable for a changelog

@github-actions github-actions bot added frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies labels Nov 8, 2024
@hipsterusername
Copy link
Member

Doesn't seem to be sized appropriately
image

@psychedelicious
Copy link
Collaborator Author

What size do you want it to be? There's not a lot of content for each video.

Also you need to update the UI dependencies.

@hipsterusername
Copy link
Member

I probably just want a bit more polished of a header in this format. I am perfecting over better. LGTM

@hipsterusername hipsterusername force-pushed the psyche/feat/ui/support-videos branch from 666b609 to 0211ea1 Compare November 19, 2024 03:35
@psychedelicious psychedelicious mentioned this pull request Nov 19, 2024
Merged
2 tasks
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/support-videos branch from 0211ea1 to b214d33 Compare November 19, 2024 21:59
@psychedelicious psychedelicious enabled auto-merge (rebase) November 19, 2024 22:01
@psychedelicious psychedelicious merged commit 7c0e70e into main Nov 19, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/support-videos branch November 19, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername