feat: ingest composition nodes into core #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
lstein,
blessedcoolant,
RyanJDick,
hipsterusername and
psychedelicious
as code owners
brandonrising
changed the title
github-actions
bot
added
python
hipsterusername
approved these changes
Nov 18, 2024
brandonrising
force-pushed
the
brandon/ingest-composition-nodes-into-core
branch
from
9bf6918
to
7364808
Compare
psychedelicious
force-pushed
the
brandon/ingest-composition-nodes-into-core
branch
from
78f0ce7
to
016f332
Compare
psychedelicious
deleted the
brandon/ingest-composition-nodes-into-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ingests a subset of the composition nodes defined in https://github.com/dwringer/composition-nodes
Specifically these:
Adjust Image Hue Plus
Blend Latents/Noise (Masked)
Enhance Image
Equivalent Achromatic Lightness
Image Layer Blend
Image Compositor
Image Dilate or Erode
Image Value Thresholds
QA Instructions
Attempt to run each of the above mentioned nodes in workflows
Merge Plan
Can be merged when tested and approved
Checklist
What's Newcopy (if doing a release after this PR)