Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): simplify logic for non-local invocation progress alerts #7353

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(ui): simplify logic for non-local invocation progress alerts #7353

merged 1 commit into from
Nov 19, 2024

Conversation

maryhipp
Copy link
Collaborator

Summary

  • do not show the setting for progress details if not local, and update component to always display non-local UI

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Nov 19, 2024
@maryhipp maryhipp merged commit f76ac18 into main Nov 19, 2024
14 checks passed
@maryhipp maryhipp deleted the maryhipp/update-invocation-progress-detail-setting branch November 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious