-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solaredge adapter to latest #1153
Conversation
You also should:
|
@92lleo Do you need any kind of support to adress the topics from above? |
@Apollon77 thanks for asking.
PS: |
|
Ah, thanks for the clarification. Changed async/timeout to async/await: 92lleo/ioBroker.solaredge@f1b1c64 |
cool, just poke when ready for next review |
@92lleo Any update? |
@92lleo Anything we can help with? |
Hello @92lleo are you ready for the next review? Do you need some help? |
@92lleo How we should continue? Can we help somehow? Should we do a PR with relevant changes? But that would still require you to verify and test and release it afterwards because the changes can only be done "blind". |
Hi @Apollon77 , @ldittmar81 |
Please approve testing for 92lleo/ioBroker.solaredge#19 |
@Apollon77 tested, reviewed & merged. Preparing the release this week. sorry for the long wait |
@92lleo any news for the release? last step missing |
@Apollon77 sorry again for the long wait.. Release is pushed and tagged -> https://github.com/92lleo/ioBroker.solaredge/releases/tag/0.3.0 |
First of all - THANK YOU for the time and effort you spend to maintain this adapter. I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.
Thanks for reading and evaluating this suggestions. |
RE-CHECK! |
Both your comments from @mcm1957 are correct and @92lleo should consider it, especially the random delays. Depending on how users use the data the delay should be static per instance that it is always 15 mins difference or it could be really dynamic (determined per run) ... @92lleo wdyt? And yes I could provide another PR for that if you like. |
Automated adapter checkerioBroker.solaredge
Add comment "RE-CHECK!" to start check anew |
Hello @mcm1957 |
Bypass commit by @GermanBluefox |
PR will be checked / closed after transfer of adapter to community area |
Adapter has been trasferred to iobroker-community-adapters orga. |
Add Solaredge Adapter
Tracked in 92lleo/ioBroker.solaredge#3