-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fully-mqtt to latest #2184
Add fully-mqtt to latest #2184
Conversation
Please add https://github.com/Acgua/ioBroker.fully-mqtt to latest.
"must be fixed" label can be removed now. I have deleted the bluefox invite, and re-invited him, and in the meantime he is listed as maintainer on npm. However, please note that I am currently working on reported issue #25. I will need to change src/lib/mqtt-server.ts, several improvements are needed. So, it may make sense that you wait with the adapter review until my changes and fixes are in place. Thanks. |
Automated adapter checkerioBroker.fully-mqtt👍 No errors found
Add comment "RE-CHECK!" to start check anew |
Please remove node 14 from test-and-release.yml and (optionally) add node 20 to testing matrix. Thanks |
I would like to give some additional (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.
Otherwise the adapter looks good to me. Thanks for reading and evaluating this suggestions. Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review! |
How shall we continue? |
How shall we continue? If we do not receive any responce within 30 days we will close this PR |
I will close this PR now. mqtt functionality is now integrated into adapter fully-browser Please feel free to open a new PR if you continue developmengt of your adapter, |
Please add https://github.com/Acgua/ioBroker.fully-mqtt to latest.
Following error will appear when executing adapter check:
I have executed the command, but invite has not yet been confirmed by bluefox.