-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rmb-bhkw to latest #2298
Add rmb-bhkw to latest #2298
Conversation
Referring to PR #1779 |
RE-CHECK! |
I've done some reReview resulting in some additional remarks. Please feel free to read them or to wait for official review by Apollon77 First of all - THANK YOU for the time and effort you spend to maintain this adapter. I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.
Some characters are not allowed to be used as part of an object id. If an object id is not hardcoded or even depending on user input you should ensure that such an object id does not contain an invalid character. Iobroker provides the constant
In addition please ensure that no spaces are within ids. As this might work, some adapter s and especially vis cannot handle ids contain ing spaces. So its highly recommended to omit spaces (and otehr whitespace characters) from ids. Further please use english text for ids and eitehr use multiplanguage naming (sopported by using an object) or use english names.
Thanks for reading and evalutaing this suggestions. @satchafunkilus |
How shall we continue? |
Any news? Please let us know if you still are woirking / maintain this adapter - a simple I'll continue as soon as I have time would be ok. If there is no reaction until 15.12.2023 this PR will be closed. @Apollon77 FYI |
I'll take a look in the upcoming days |
Changed logging to english only
Set objects to readonly
Done
Done
Switched to English
Done
This was already the case - a random delay between 0 and 60 seconds is added to the pull interval
Added tests for node 20
This is not the case - using intervals with random delay rather than fixed timestamps |
Automated adapter checkerioBroker.rmb-bhkw👍 No errors found
Add comment "RE-CHECK!" to start check anew |
Some more (non blocking) remarks:
|
This adapter has been released to latest repository and should be visible within 24h maximum. Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later. Note: If an other testing topic already exists, ist OK to continue using this topic too. |
Please add my adapter ioBroker.rmb-bhkw to latest.
This pull request was created by https://www.iobroker.dev c0726ff.
THIS IS A REPLACEMENT FOR #1779
PLEASE SEE DISCUSSION AT #1779