Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minuvis to 2.3.3 at stable #2713

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Update minuvis to 2.3.3 at stable #2713

merged 1 commit into from
Oct 20, 2023

Conversation

SVallant
Copy link
Contributor

@SVallant SVallant commented Oct 1, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 1, 2023
@mcm1957 mcm1957 changed the title Update stable version of minuvis in repo from 2.2.0 to 2.3.3 Update minuvis to 2.3.3 at stable Oct 1, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2023

@SVallant

Your adapter https://github.com/minukodu/ioBroker.minuvis does not use standard iobroker testing.

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in forum from apollon77 (Just take from other adapters the samples)

You may copy the test-and-release.yml workflow from the example adapter or newly created adapter. If you need help, please let uas know.

Please feel free if you need any help setting up standard testing and / or if you prefer a PR to fix this.

Please add a comment when you have reviewed and fixed the suggestion or at least commented the suggestions and you think the adapter is ready for a re-review

@SVallant
Copy link
Contributor Author

SVallant commented Oct 1, 2023

clase pull request, adpater does not have standard iobroker testing.

@SVallant SVallant closed this Oct 1, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2023

Why did you close the PR?

Standard GH testing is required for all Adapters and should not be a big problem.
If you need any help, please let us know.

Or do you want the adapter to be removed from the repositories?

@SVallant
Copy link
Contributor Author

SVallant commented Oct 1, 2023

i closed this because i have to update the adapter and then a have new version number
is this wrong ?

Or do you want the adapter to be removed from the repositories? NO

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2023

Updates to the adapter repository are needed.

A new version is NOT needed as long the tests do not show a problem with the adapter. The std. github tests are run at every commit, so even adding a space to README.md will trigger them.

If no change to code is required no new release is required.

Most likely the lint check will throw issues. Its OK to disable it at the first pass (lint:false at workflow). But I strongly suggest to enable it later and fix the issues. As this will require code changes (and even if only changeing single an ddouble quortes) a test is strongly recommended. So if linter throws issues I suggest to disable it now to minimize your workload, create a issue and process it when you are working at the adapter the next time.

Martin (mcm1957)

@SVallant
Copy link
Contributor Author

SVallant commented Oct 1, 2023

ok

@SVallant SVallant reopened this Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Automated adapter checker

ioBroker.minuvis

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W164] Adapters without config "common.noConfig = true" should also set "common.adminUI.config = none"
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 1, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 20, 2023

Sorry for late feedback.

I must revise my reqeust to add standard ioBroker github testing. I just detected that your adapetr deos NOT provide any adapter code, it contains only a www component. So standard github tests do not provide any testing / are not possible at all.

Sorry for the fact that I dod not notice that at the first look.

I'll continuie with the stable upgrade now.

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 20, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 20, 2023

2.3.3 created 04.04.2023
OK

@mcm1957 mcm1957 merged commit a52c47e into ioBroker:master Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants