-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minuvis to 2.3.3 at stable #2713
Conversation
Your adapter https://github.com/minukodu/ioBroker.minuvis does not use standard iobroker testing. Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository
You may copy the Please feel free if you need any help setting up standard testing and / or if you prefer a PR to fix this. Please add a comment when you have reviewed and fixed the suggestion or at least commented the suggestions and you think the adapter is ready for a re-review |
clase pull request, adpater does not have standard iobroker testing. |
Why did you close the PR? Standard GH testing is required for all Adapters and should not be a big problem. Or do you want the adapter to be removed from the repositories? |
i closed this because i have to update the adapter and then a have new version number Or do you want the adapter to be removed from the repositories? NO |
Updates to the adapter repository are needed. A new version is NOT needed as long the tests do not show a problem with the adapter. The std. github tests are run at every commit, so even adding a space to README.md will trigger them. If no change to code is required no new release is required. Most likely the lint check will throw issues. Its OK to disable it at the first pass (lint:false at workflow). But I strongly suggest to enable it later and fix the issues. As this will require code changes (and even if only changeing single an ddouble quortes) a test is strongly recommended. So if linter throws issues I suggest to disable it now to minimize your workload, create a issue and process it when you are working at the adapter the next time. Martin (mcm1957) |
ok |
Automated adapter checkerioBroker.minuvis👍 No errors found
Add comment "RE-CHECK!" to start check anew |
Sorry for late feedback. I must revise my reqeust to add standard ioBroker github testing. I just detected that your adapetr deos NOT provide any adapter code, it contains only a www component. So standard github tests do not provide any testing / are not possible at all. Sorry for the fact that I dod not notice that at the first look. I'll continuie with the stable upgrade now. |
2.3.3 created 04.04.2023 |
No description provided.