Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vis-homekittiles to latest #2756

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Standarduser
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Oct 14, 2023
@mcm1957 mcm1957 added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. *📬 a new comment has been added and removed *📬 a new comment has been added labels Oct 15, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 21, 2023

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review and removed RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Oct 21, 2023
@github-actions github-actions bot added the *📬 a new comment has been added label Nov 1, 2023
@github-actions github-actions bot deleted a comment from Standarduser Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Automated adapter checker

ioBroker.vis-homekittiles

Downloads
NPM

👍 No errors found

  • 👀 [W400] Cannot find "vis-homekittiles" in latest repository

Add comment "RE-CHECK!" to start check anew

@Standarduser
Copy link
Contributor Author

@mcm1957 Alle Punkte erledigt. Allerdings bin ich nicht damit einverstanden, dass die Readme nicht in Deutsch sein darf. Wenn man mal darüber nachdenkt, dann macht das auch keinen Sinn. Ich muss den deutschen Text ins englische übersetzen, damit er dann automatisch wieder ins Deutsche übersetzt werden kann.
Es ist völlig ok, wenn Englisch (zusätzlich) verlangt wird, aber andere Sprachen zu verbannen ist eine schlechte Lösung und kann letztlich nur zum Schaden der Nutzer sein.

Wie auch immer, ich habs jetzt trotzdem angepasst und bitte um das Review.

@mcm1957 mcm1957 added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. lgtm Looks Good To Me and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Nov 2, 2023
@mcm1957 mcm1957 requested review from Apollon77 and removed request for Apollon77 November 2, 2023 20:56
@mcm1957 mcm1957 merged commit 2a95cba into ioBroker:master Nov 2, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias lgtm Looks Good To Me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants