Update Stable versions (27 adapter) #2779

TA2k · 2023-10-18T08:40:29Z

No description provided.

mcm1957 · 2023-10-18T09:36:52Z

Please split updates into seperate PRs per adapter and fix issues reported by adapter checker to handle checks / and processing independently.

Please verify that:

Adapters have release information added to README.md (Error 606 must be fixed)
Verify that README,md is written in (pure) english.
translations are present at io-package.json (at least english and german is mandatory)
github tests for node 16/18/20 are implemented and working

Note: Error 605 and 701 (copyright year missing) can be ignored!

TA2k · 2023-10-18T09:38:25Z

Sorry I have not time for this. Please close or merge

mcm1957 · 2023-10-18T09:44:12Z

In addition please state why you request stable updates for adapters you die not work on lately. I.e. worx has been maintained by lucky-esa lately. Dis you discusse with him to request an update of stable? It would be at least good practice to ask the (active) maintainer in my oppinion

And of course npm access must be fixed too. All adapters require bluefox as owner.

mcm1957 · 2023-10-18T09:45:23Z

I will close here - please create seperate PRs. Using www.iobroker.dev this should a one click action (if all adater passes checks withpiut errors.)

@Apollon77 FYI

mcm1957 · 2023-10-18T13:04:54Z

@TA2k

Sorry I have not time for this. Please close or merge

Please explain what actions are too much timeconsuming.
If splitting the PR is the problem - well can be handled as ONE PR too.

But the mentioned / reported issues

missing releasenotes entry at README.md
missing access to npm for bluefox
missing translations for news (de, en required, rest optional)
miccing common.connectionType and common.dataSource

shouldn't be a problem to fix as those information directly effects the users comfort when using / installing the adapter.

Please let me know, if you plan to fix / have fixed those issues so that I can do a selective merge when fixed.

TA2k · 2023-10-18T13:41:40Z

Release notes are in io-package.json
npm access was invited but not accepted
if the same text in German as in English no translation needed
this are old adapters the user never saw the information for connectionType and was fine with this

working adapter version is more important then copyright in readme, bad auto translated changelog or comfort infos like connectionType

mcm1957 · 2023-10-18T13:52:05Z

Release notes are in io-package.json

All other developers provide releasenote information within README.md. This place is looked by users too without havin to know where it is located. Besides older releasenotes are removed from io-package.json

npm access was invited but not accepted

Please reinvite him

if the same text in German as in English no translation needed

well, I assume you can translate the text to german - so its not the same text. I did not clearly state in my last posting, that EN and DE are required and the rest is optional. Sorry if confusing).

this are old adapters the user never saw the information for connectionType and was fine with this

Well - but that should not prohibit the correction / adaption to current standards

working adapter version is more important then copyright in readme, bad auto translated changelog or comfort infos like connectionType

I agree but I did not list copyright years as a problem and I did not require autotranslated changelogs. Complete io-package contents should not be such a problem if the adapetr will claim to be up to date.

github-actions · 2023-10-18T21:32:01Z

Automated adapter checker

ioBroker.bmw

ioBroker.botslab360

❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 TA2k [email protected]" at the end of README.md
❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 TA2k [email protected]" at the start of LICENSE
👀 [W171] "common.title" is deprecated in io-package.json
👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W202] Version of package.json (0.0.2) doesn't match latest version on NPM (0.1.0)
👀 [W515] Why you decided to disable i18n support?

ioBroker.fiat

ioBroker.ford

ioBroker.garmin

❗ [E802] No topics found in the repository. Please go to "https://github.com/TA2k/ioBroker.garmin", press the settings button beside the about title and add some topics.
❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 TA2k [email protected]" at the end of README.md
❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 TA2k [email protected]" at the start of LICENSE
👀 [W171] "common.title" is deprecated in io-package.json
👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W515] Why you decided to disable i18n support?

ioBroker.hoover

ioBroker.imow

❗ [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.imow
❗ [E606] Current adapter version 0.1.0 not found in README.md
❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 TA2k [email protected]" at the end of README.md
❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 TA2k [email protected]" at the start of LICENSE
👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W515] Why you decided to disable i18n support?

ioBroker.mihome-cloud

❗ [E606] Current adapter version 0.1.1 not found in README.md
👀 [W171] "common.title" is deprecated in io-package.json
👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W515] Why you decided to disable i18n support?

ioBroker.nissan

ioBroker.onvif

👍 No errors found

👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W515] Why you decided to disable i18n support?
👀 [W504] setInterval found in "main.js", but no clearInterval detected
👀 [W505] setTimeout found in "main.js", but no clearTimeout detected

ioBroker.parcel

ioBroker.porsche

ioBroker.psa

ioBroker.radar2

ioBroker.renault

ioBroker.smart-eq

ioBroker.smartthings

ioBroker.tesla-motors

👍 No errors found

ioBroker.toyota

ioBroker.vaillant

ioBroker.vesync

ioBroker.viessmannapi

ioBroker.vw-connect

ioBroker.weishaupt-wem

ioBroker.wmswebcontrol

ioBroker.worx

👍 No errors found

ioBroker.zehnder-cloud

❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 TA2k [email protected]" at the end of README.md
❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 TA2k [email protected]" at the start of LICENSE
👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

Update sources-dist-stable.json

bff5bf1

github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Oct 18, 2023

mcm1957 added cancellation of PR suggested The adapter needs significant rework before a review seems to be appropiate ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 18, 2023

mcm1957 changed the title ~~Update Stable versions~~ Update Stable versions (27 adapter) Oct 18, 2023

github-actions bot added the *📬 a new comment has been added label Oct 18, 2023

mcm1957 closed this Oct 18, 2023

mcm1957 removed ON HOLD PR is set ON HOLD due to pending question or major issues. *📬 a new comment has been added labels Oct 18, 2023

github-actions bot added the *📬 a new comment has been added label Oct 18, 2023

mcm1957 removed the *📬 a new comment has been added label Oct 18, 2023

mcm1957 reopened this Oct 18, 2023

github-actions bot deleted a comment from mcm1957 Oct 18, 2023

mcm1957 added ON HOLD PR is set ON HOLD due to pending question or major issues. and removed cancellation of PR suggested The adapter needs significant rework before a review seems to be appropiate labels Oct 18, 2023

github-actions bot deleted a comment from mcm1957 Oct 18, 2023

mcm1957 closed this Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Stable versions (27 adapter) #2779

Update Stable versions (27 adapter) #2779

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 •

edited

Loading

mcm1957 commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 •

edited

Loading

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

Update Stable versions (27 adapter) #2779

Update Stable versions (27 adapter) #2779

Conversation

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 • edited Loading

mcm1957 commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 • edited Loading

TA2k commented Oct 18, 2023

mcm1957 commented Oct 18, 2023 • edited Loading

github-actions bot commented Oct 18, 2023

Automated adapter checker

mcm1957 commented Oct 18, 2023 •

edited

Loading

mcm1957 commented Oct 18, 2023 •

edited

Loading

mcm1957 commented Oct 18, 2023 •

edited

Loading