Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iwg-vpn to 2.0.5 at stable #2805

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Bump iwg-vpn to 2.0.5 at stable #2805

merged 1 commit into from
Oct 24, 2023

Conversation

iwg-vpn
Copy link
Contributor

@iwg-vpn iwg-vpn commented Oct 19, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 19, 2023
@mcm1957 mcm1957 changed the title new iwg-vpn stable version Bump iwg-vpn to 2.5 at stable Oct 19, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 19, 2023

Your adapter https://github.com/iwg-vpn/ioBroker.iwg-vpn does not use standard iobroker testing.

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository which is also required for stable repository.

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in forum from apollon77 (Just take from other adapters the samples)

You may copy the test-and-release.yml workflow from the example adapter or newly created adapter. If you need help, please let uas know.

If you need any help setting up standard testing and / or if you prefer a that we / I create a PR to fix this please let us know.

Please add a comment when you have reviewed and fixed the suggestion or at least commented the suggestions and you think the adapter is ready for a re-review

NOTE: No new release is required as long as standard test pass. It's ok to disable lint for the first time as linter might require quality changes which are not required at high priority. It's sufficient to enable lint with standard setupo for the next release. But standard node tests for nod 16/18/20 are mandatory

@mcm1957 mcm1957 added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Oct 19, 2023
@iwg-vpn
Copy link
Contributor Author

iwg-vpn commented Oct 19, 2023

test-and-release.yml was added

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 19, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 20, 2023

2.0.5 created 17.10.2023

@mcm1957 mcm1957 added STABLE - brand new and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Oct 20, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 24, 2023

2.0.5 created 17.10.2023
12 user (4%)
OK

@github-actions github-actions bot deleted a comment from mcm1957 Oct 24, 2023
@mcm1957 mcm1957 changed the title Bump iwg-vpn to 2.5 at stable Bump iwg-vpn to 2.0.5 at stable Oct 24, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.iwg-vpn

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 24, 2023

@iwg-vpn

Please honor version numbering for the next release:

objects API introduced

for sure is not only a bug fix but introduces a new feature. So this release should have been a minor release (at least)

increase patch version for releases including fixes only, but do not provide new features and are not breaking
increase minor version for releases including new feature (may contain bugfixes)
increase major version for releases including breaking changes ('something incompatible')

Thanks in advance

(This remark does not blcok 2.0.5 to be released at stable for now)

@mcm1957 mcm1957 merged commit 45b5660 into ioBroker:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants