Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylontech 0.0.6 to stable #2823

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add pylontech 0.0.6 to stable #2823

merged 2 commits into from
Oct 23, 2023

Conversation

PLCHome
Copy link
Contributor

@PLCHome PLCHome commented Oct 23, 2023

44 Installation no issues.
The discussion in the forum is positive.
https://forum.iobroker.net/topic/68707/

44 Installation no issues.
The discussion in the forum is positive.
https://forum.iobroker.net/topic/68707/
44 Installation no issues.
The discussion in the forum is positive.
https://forum.iobroker.net/topic/68707/
@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 23, 2023
@PLCHome
Copy link
Contributor Author

PLCHome commented Oct 23, 2023

i used npm run addToSatble -- --name pylontech --version 0.0.6
After that is not working: "Check stable versions / check stable versions (pull_request)"

This function seems to delete a LF at the end of the file. I added the LF back in and now it works.
If you add an unstable version, a lot of adapters are also touched.
Maybe these tool need an overhaul.

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 23, 2023
@mcm1957 mcm1957 changed the title Push 0.0.6 to stable Add pylontech 0.0.6 to stable Oct 23, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.pylontech

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added new at STABLE and removed *📬 a new comment has been added labels Oct 23, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 23, 2023

0.0.6 created 09.10.2023
40 user
OK

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 23, 2023

i used npm run addToSatble -- --name pylontech --version 0.0.6 After that is not working: "Check stable versions / check stable versions (pull_request)"

This function seems to delete a LF at the end of the file. I added the LF back in and now it works. If you add an unstable version, a lot of adapters are also touched. Maybe these tool need an overhaul.

The referenced test fauile because of
Icon of adapter smartmeter: https://raw.githubusercontent.com/Apollon77/ioBroker.smartmeter/master/admin/smartmeter.png not gettable

Those kind of errors are reviewed manually.

Adding / removing a terminating LF only caused the test to repeated.

@mcm1957 mcm1957 merged commit 93ae496 into ioBroker:master Oct 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias new at STABLE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants