Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zendure-solarflow to latest #2831

Closed
wants to merge 1 commit into from
Closed

Add zendure-solarflow to latest #2831

wants to merge 1 commit into from

Conversation

nograx
Copy link
Contributor

@nograx nograx commented Oct 27, 2023

Please add my adapter ioBroker.zendure-solarflow to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Oct 27, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.zendure-solarflow

Downloads
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W400] Cannot find "zendure-solarflow" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added the RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. label Oct 27, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 27, 2023

Thanks for spening you time to develop an adapter for ioBroker.

I'll du a detailled review the next days, but in the meantime fix issues causing the standard github tests to fail.

  • fix linter errors and warningd
  • ensure that integration tests do not fail (Adapter should not terminate with error if config is missing, logging an error log ishould be enough
  • please note that standard github tests are mandator, so removing them is not an option.

image

@mcm1957 mcm1957 added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Oct 27, 2023
@nograx nograx closed this Oct 27, 2023
@nograx nograx deleted the zendure-solarflow-to-latest branch October 27, 2023 18:51
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 27, 2023

Just for Inof:
Theres no need to close the PR to process feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nograx @mcm1957