-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumb TibberLink stable to 1.4.1 #2838
Conversation
Automated adapter checkerioBroker.tibberlink👍 No errors found
Add comment "RE-CHECK!" to start check anew |
must be checked label seems to be false positive because of verification of newer version 1.4.2 - the there found issue has been fixed in between, so also this error isn't found anymore |
1.4.1 created 25.10.2023 |
Those warnings / Errors are can be avoided if you do not change version numbers manually asynchronous to releasing a new version but change them using the releasescript during releasing the version. But in anyway all errors / warnings will be manually reviewed and if the are casused by some changes for future versions they will be ignored. So no need to fic them explicitly. In addition consider removing old(er) npm_publish script and use integrated publisching with test-and-release script (by uncommenting the sequence) Finally, you have configured adapter tests using node 18 and node 20. So this adapter must required node 18 minimum. Please merge my PR. If you want to support node 16 although its EOL please adapt testing matrix and drop PR. A new release is NOT required, Fix for next release is OK. |
Brand new?? There are 900 people using the actual stable version 1.0.0 ?!?!?! |
Please read the text above, If you have suggestions to make it more clear, they are welcome. |
No description provided.