Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumb TibberLink stable to 1.4.1 #2838

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Bumb TibberLink stable to 1.4.1 #2838

merged 1 commit into from
Nov 1, 2023

Conversation

hombach
Copy link
Contributor

@hombach hombach commented Oct 29, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Oct 29, 2023
@github-actions github-actions bot deleted a comment from hombach Oct 29, 2023
@github-actions github-actions bot deleted a comment from hombach Oct 29, 2023
@github-actions github-actions bot deleted a comment from hombach Oct 29, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.tibberlink

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W202] Version of package.json (1.4.2) doesn't match latest version on NPM (1.4.1)

Add comment "RE-CHECK!" to start check anew

@hombach
Copy link
Contributor Author

hombach commented Oct 29, 2023

must be checked label seems to be false positive because of verification of newer version 1.4.2 - the there found issue has been fixed in between, so also this error isn't found anymore

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Oct 29, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 29, 2023

1.4.1 created 25.10.2023
91 User
OK

@mcm1957 mcm1957 added STABLE - brand new and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Oct 29, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 29, 2023

must be checked label seems to be false positive because of verification of newer version 1.4.2 - the there found issue has been fixed in between, so also this error isn't found anymore

Those warnings / Errors are can be avoided if you do not change version numbers manually asynchronous to releasing a new version but change them using the releasescript during releasing the version.

But in anyway all errors / warnings will be manually reviewed and if the are casused by some changes for future versions they will be ignored. So no need to fic them explicitly.

In addition consider removing old(er) npm_publish script and use integrated publisching with test-and-release script (by uncommenting the sequence)

Finally, you have configured adapter tests using node 18 and node 20. So this adapter must required node 18 minimum. Please merge my PR. If you want to support node 16 although its EOL please adapt testing matrix and drop PR. A new release is NOT required, Fix for next release is OK.

@hombach
Copy link
Contributor Author

hombach commented Oct 29, 2023

Brand new?? There are 900 people using the actual stable version 1.0.0 ?!?!?!

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 29, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 29, 2023

Brand new?? There are 900 people using the actual stable version 1.0.0 ?!?!?!

Please read the text above, If you have suggestions to make it more clear, they are welcome.
1.0.0 is irrelevant. 1.4.1 is requested to be listed at stable. It has been created at at 25.10.2023 and this release is only 4 days old.

@mcm1957 mcm1957 removed *📬 a new comment has been added STABLE - brand new labels Oct 29, 2023
@mcm1957 mcm1957 merged commit d41f72e into ioBroker:master Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants