Add jablotron to latest

[DEV2DEV-DE]

Please add my adapter ioBroker.jablotron to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

[github-actions]

Automated adapter checker

ioBroker.bosesoundtouch

• ❗ [E114] No adapter are allowed in the repo without admin support (set "common.noConfig = true" and "common.adminUI.config = none" if adapter has no configuration)
• ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2019-2023 sven_s_ter [email protected]" at the end of README.md
• ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2019-2023 sven_s_ter [email protected]" at the start of LICENSE
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

ioBroker.jablotron

👍 No errors found

• 👀 [W400] Cannot find "jablotron" in latest repository

Add comment "RE-CHECK!" to start check anew

[ticaki]

In order to relieve mcm, I have looked at the adapter and the following points need to be corrected first:

• Do not overwrite a class member function in an incompatible way. This works, but the error message in the IDE is confusing and is not defined in this way.
  https://github.com/DEV2DEV-DE/ioBroker.jablotron/blob/cb5fef106e71a3328587dc3d561fd47f299bbdef/main.js#L321
  createState() is a function of utils.Adapter - Please rename it in customCreateState() or what ever u want.

• You use Adapter.clearTimeout() this timeout must be started with Adapter.setTimeout().
  https://github.com/DEV2DEV-DE/ioBroker.jablotron/blob/cb5fef106e71a3328587dc3d561fd47f299bbdef/main.js#L157

• There is a missing dependencies for axios in ur package.json use npm i axios to add it.

Optional not required for lastest:

• as i told u in chat. common.type=object not really exist. A datapoint with this common type is not used by anything in iobroker. The correct way to write a Json-Object into data points is common.type=string common.role=json
  https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md#common

• I think there will probably be states you want to react to in the future, otherwise this.on('stateChange', this.onStateChange.bind(this)); (and onStateChange()) would have to be removed.

[DEV2DEV-DE]

@ticaki
All mentioned improvements have been implemented.
You are right with the last topic. There will be states to react on in the future. Therefore, the binding to 'stateChange' has been prepared.

[mcm1957]

@DEV2DEV-DE

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

• sensitive information, especially passwords should be stored encrypted

  You configuration seems to contain passwords (or other sensitive information) which is not stored encrypted. As long as those information is not stored inside a table you can encrypt and secure this infomation simply by adding the following configuration to io-package.json. The iob runtime will encrypt / decrypt the data as required; no addition programming effort is required. Note that users will need to reenter this info one time after adding encryption, so drop a note at release notes.

  "encryptedNative": [
    "password",
    "data2"
  ],
  "protectedNative": [
    "password",
    "data2"
  ],
  

• info.connection does not need to be created
  info.connection is normally defined at iio-package.json and hence need not be created within code. You should add the state at io-pacge.json (see template or other adapters for an example) and remove the code part.
  https://github.com/DEV2DEV-DE/ioBroker.jablotron/blob/569fe788b4ebc6a5a69d9f0f3ccd0b92d7239ea2/main.js#L397C39-L397C43

• unused onStateChange handler

  You configred an onStateChange handler but it looks like this handler does not do any important tasks. Please remove the handler if the adapter does not react on state changes.

  If you plan to use it later, its ok the comment it out only.

• add minimum (and eventully maximum) limits to pollintervall
  adding a lower (and opionally an upper) limit to pollintervall at jsonConfig reduces the chance that a user will enter an invalid value and run into an exception at adapter start.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

[DEV2DEV-DE]

All mentioned improvements have been fixed/implemented.

@mcm1957
Bin ja selbst ein Verfechter von "auskommentierter Code hat im Release nix verloren".
Wozu hat man schließlich eine Versionsverwaltung? Kann man sich ja später wieder zurückholen.

[mcm1957]

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " (if not already done) to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, ist OK to continue using this topic too.