Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setStableTag script #3078

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Add setStableTag script #3078

merged 2 commits into from
Dec 18, 2023

Conversation

mcm1957
Copy link
Collaborator

@mcm1957 mcm1957 commented Dec 18, 2023

No description provided.

@mcm1957 mcm1957 merged commit d514aca into ioBroker:master Dec 18, 2023
5 checks passed
@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Dec 18, 2023
Copy link

Automated adapter checker

ioBroker.apg-info

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the start of LICENSE
  • 👀 [W515] Why you decided to disable i18n support?

ioBroker.followthesun

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the start of LICENSE
  • 👀 [W515] Why you decided to disable i18n support?

ioBroker.frigate

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.fuelpricemonitor

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the start of LICENSE
  • 👀 [W515] Why you decided to disable i18n support?

ioBroker.openknx

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

ioBroker.tinymqttbroker

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 HGlab01 [email protected]" at the start of LICENSE

ioBroker.vis

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

ioBroker.tedee

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W515] Why you decided to disable i18n support?

ioBroker.vis-2-widgets-radar-trap

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.webcal

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.zendure-solarflow

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

Add comment "RE-CHECK!" to start check anew

const files = await getGithub(`https://api.github.com/repos/ioBroker/ioBroker.repositories/pulls/${prID}/files`);
console.log('Files changed:');
files.forEach( f=>{console.log(` ${f}`)});
const isStable = files.includes(`${STABLE_JSON}`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
const npmRelease = npmTags.stable;
//console.log( `repo: ${repoRelease} - npm: ${npmRelease}`);
if (repoRelease === npmRelease) {
console.log (`${adapter} ${repoRelease} correctly tagged as stable`)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
console.log( `executing npm --//registry.npmjs.org/:_authToken=*** dist-tag add iobroker.${adapter}@${repoRelease} stable`);
const cmd = `npm --//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN} dist-tag add iobroker.${adapter}@${repoRelease} stable`;
try {
const result=execSync( cmd, { encoding: 'utf-8' });

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
console.log( `executing npm --//registry.npmjs.org/:_authToken=*** dist-tag add iobroker.${adapter}@${repoRelease} stable`);
const cmd = `npm --//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN} dist-tag add iobroker.${adapter}@${repoRelease} stable`;
try {
const result=execSync( cmd, { encoding: 'utf-8' });

Check warning

Code scanning / CodeQL

Indirect uncontrolled command line Medium

This command depends on an unsanitized
environment variable
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant