Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myuplink to latest #3120

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add myuplink to latest #3120

merged 1 commit into from
Jan 14, 2024

Conversation

sebilm
Copy link
Contributor

@sebilm sebilm commented Dec 25, 2023

Tested by user (and me): sebilm/ioBroker.myuplink#1

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Dec 25, 2023
@mcm1957 mcm1957 changed the title Update sources-dist.json: Add myuplink adapter Add myuplink to latest Dec 25, 2023
@mcm1957 mcm1957 added the RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. label Dec 25, 2023
@github-actions github-actions bot added the *📬 a new comment has been added label Dec 25, 2023
@github-actions github-actions bot deleted a comment from sebilm Dec 25, 2023
@mcm1957 mcm1957 removed *📬 a new comment has been added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Dec 25, 2023
@github-actions github-actions bot added the *📬 a new comment has been added label Dec 28, 2023
@github-actions github-actions bot deleted a comment from sebilm Dec 28, 2023
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Dec 28, 2023
@sebilm
Copy link
Contributor Author

sebilm commented Jan 2, 2024

Is anything else needed from me here?

@github-actions github-actions bot added the *📬 a new comment has been added label Jan 2, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jan 2, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 2, 2024

Is anything else needed from me here?

No - not at the moment
PR is waiting for review currently.

@sebilm
Copy link
Contributor Author

sebilm commented Jan 2, 2024

Ok, thanks

@github-actions github-actions bot added the *📬 a new comment has been added label Jan 2, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jan 2, 2024
@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Jan 10, 2024
@github-actions github-actions bot deleted a comment from mcm1957 Jan 10, 2024
@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Jan 10, 2024
@sebilm
Copy link
Contributor Author

sebilm commented Jan 10, 2024

Das macht mich jetzt schon etwas sprachlos. Das liegt der Pullrequest jetzt so lange rum, dass sich das Jahr inzwischen geändert hat und deshalb steht er jetzt auf musst fix. Man, man, man. Sorry, aber das musste ich jetzt mal los werden.

@github-actions github-actions bot added the *📬 a new comment has been added label Jan 10, 2024
@github-actions github-actions bot deleted a comment from sebilm Jan 10, 2024
@github-actions GitHub Actions
Copy link

Automated adapter checker

ioBroker.myuplink

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W400] Cannot find "myuplink" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review and removed RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. *📬 a new comment has been added labels Jan 10, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 10, 2024 •
edited
Loading

Das macht mich jetzt schon etwas sprachlos. Das liegt der Pullrequest jetzt so lange rum, dass sich das Jahr inzwischen geändert hat und deshalb steht er jetzt auf musst fix. Man, man, man. Sorry, aber das musste ich jetzt mal los werden.

Nö - das Flag war zu dem Zeitpunkt schon entfernt - da z.Z. irrelevant.
Trotzdem DANKE fürs anpassen.

image

P.S: Nach Review hab ichs aber wieder gesetzt,...

@sebilm
Copy link
Contributor Author

sebilm commented Jan 13, 2024

Thank you for reviewing my code. I have made the desired changes.

@github-actions github-actions bot added the *📬 a new comment has been added label Jan 13, 2024
@mcm1957 mcm1957 added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. and removed *📬 a new comment has been added labels Jan 13, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 13, 2024

reminder 15.1.2024

@mcm1957 mcm1957 added lgtm Looks Good To Me and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. 15.1.2024 labels Jan 14, 2024
@mcm1957 mcm1957 merged commit bf20a4b into ioBroker:master Jan 14, 2024
40 checks passed
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 14, 2024

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, ist OK to continue using this topic too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Apollon77 Apollon77

Labels
auto-checked This PR was automatically checked for obvious criterias lgtm Looks Good To Me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebilm @mcm1957 @Apollon77