Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deconz to 1.4.0 #3399

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update deconz to 1.4.0 #3399

merged 1 commit into from
Mar 12, 2024

Conversation

Jey-Cee
Copy link
Contributor

@Jey-Cee Jey-Cee commented Mar 12, 2024

Please update my adapter ioBroker.deconz to version 1.4.0.

This pull request was created by https://www.iobroker.dev c0726ff.

Copy link

Automated adapter checker

ioBroker.deconz

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

Adapter releases: https://www.iobroker.dev/adapter/deconz/releases
Adapter statistic: https://www.iobroker.dev/adapter/deconz/statistics

History and usage information for release 1.4.0:

1.4.0 created 29.1.2024 (42 days old)
359 users (4.62%)

1.3.23 (stable) created 5.11.2023 (128 days old)
4333 users (stable) (55.79%)

Please verify that this PR really tries to update to release 1.4.0!

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

@Jey-Cee
Does version 1.4.0 require a paid license or is it still free?

EDIT: Answered at issue.
1.4.0 is still free.

@mcm1957 mcm1957 added question Something needs to be done or answered by the adapter developer and removed question Something needs to be done or answered by the adapter developer labels Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

Please consider using / adding standard test-and-release workflow with next / new releases. You can of course use your own tests too. This allows faster processing of checks.

As standard test-and.release workflow seems to missing currently, this test must be done manually which might cause some delay for release.

reminder 13.3.2024

@mcm1957 mcm1957 added the RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. label Mar 12, 2024
@Jey-Cee
Copy link
Contributor Author

Jey-Cee commented Mar 12, 2024

Do you mean this one: https://github.com/Jey-Cee/ioBroker.deconz/blob/master/.github/workflows/test_and_release.yml
That is the standard but not up to date and with a small change that chooses the nodejs versions for testing from ioBroker installation.

@github-actions github-actions bot added the *📬 a new comment has been added label Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

Yes I refer to this.
But the content is not standard nor is the name.

It does not use i.e.

ioBroker/testing-action-check@v1
ioBroker/testing-action-adapter@v1

etc.

Feel free to use your own testing. Its always goog to do a maximum of testing. But standard workflow should be used an pass. If an adapter does not use standard wirkflow I will do the test manually within a fork. If tests pass all is OK, otherwise a feedback will be given. But this might delay release of yourse.

If preferred I can prvide a PR with actual workflow. As the name differs anyway, those test could be simple added

@mcm1957 mcm1957 removed *📬 a new comment has been added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Mar 12, 2024
@mcm1957 mcm1957 merged commit d1bc673 into ioBroker:master Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants