Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nmea to latest #3409

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Added nmea to latest #3409

merged 1 commit into from
Mar 17, 2024

Conversation

GermanBluefox
Copy link
Contributor

No description provided.

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Mar 17, 2024
@github-actions github-actions bot deleted a comment from GermanBluefox Mar 17, 2024
@github-actions github-actions bot deleted a comment from GermanBluefox Mar 17, 2024
@github-actions GitHub Actions
Copy link

Automated adapter checker

ioBroker.nmea

Downloads Number of Installations (latest) - Test and Release
NPM

👍 No errors found

  • 👀 [W400] Cannot find "nmea" in latest repository
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 17, 2024

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

You will find the results of the review and evntually issues / suggestings as a communt to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.

mcm1957

@mcm1957 mcm1957 added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Mar 17, 2024
@GermanBluefox GermanBluefox merged commit fd50435 into master Mar 17, 2024
13 checks passed
@mcm1957 mcm1957 added BYPASS processed using bypass access and removed RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Mar 17, 2024
@mcm1957 mcm1957 added the lgtm Looks Good To Me label Mar 17, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 17, 2024

For review remarks see
ioBroker/ioBroker.nmea#14

@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 17, 2024

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, it' OK to continue using this topic too.

@mcm1957 mcm1957 deleted the nmea branch April 4, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Apollon77 Apollon77

Labels
auto-checked This PR was automatically checked for obvious criterias BYPASS processed using bypass access lgtm Looks Good To Me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermanBluefox @mcm1957 @Apollon77