SANTA-222: symfony upgrade #581
Conversation
|
@ChuckCCW the tests fail, you can have a look and clear any errors until they are green. I think if you push a new test run starts, if not let me know! |
|
@ChuckCCW is the MR is ready to go? |
config/services.yaml
Outdated
| $mailer: '@swiftmailer.mailer.standard_mailer' | ||
| $mandrill: '@swiftmailer.mailer.mandrill_mailer' | ||
| $mailer: '@mailer' | ||
| $mandrill: '@mailer' |
There was a problem hiding this comment.
dit zijn 2 aparte mailers, eentje via localhost (standard mailer) en eentje via mandrill. De code kiest op basis van het domein welke mailer er gebruikt wordt https://github.com/iodigital-com/SecretSanta/blob/master/src/Mailer/MailerService.php#L571 Maar deze change zet dus alles op de default mailer
| defaults: | ||
| _controller: Symfony\Bundle\FrameworkBundle\Controller\TemplateController::templateAction | ||
| template: 'Static/cookiePolicy.html.twig' | ||
|
|
||
| ecofriendly1: | ||
| path: /eco-friendly-tips | ||
| path: /{_locale}/eco-friendly-tips |
There was a problem hiding this comment.
de URL's zonder locale werken niet meer, dat zijn net de URL's die in google zitten volgens mij. De pagina zonder locale zou op de EN versie moeten uitkomen
src/Command/ExportMailsCommand.php
Outdated
| protected function configure() | ||
| { | ||
| protected function configure(): void | ||
| { |
src/Command/HashOldDataCommand.php
Outdated
| protected function configure() | ||
| { | ||
| protected function configure(): void | ||
| { |
| public function editParticipantAction(Request $request, string $listurl, Participant $participant, ParticipantService $participantService, MailerService $mailerService) | ||
| { | ||
| /** | ||
| * @throws TransportExceptionInterface |
There was a problem hiding this comment.
Dit is een HTTP endpoint, die zouden geen exceptions meer mogen throwen. Of het voelt althans niet correct om het hie zo te documenteren.
| $em->persist($assignedParticipant); | ||
| $em->flush(); | ||
| if ($assignedParticipant) { | ||
| $assignedParticipant->setAssignedParticipant($secretSanta); |
| * @Route("/participant/{url}", name="participant_view", methods={"GET"}) | ||
| * @Template("Participant/show/valid.html.twig") | ||
| */ | ||
| #[Route("/{_locale}/participant/{url}", name: "participant_view", methods: ["GET"])] |
There was a problem hiding this comment.
misschien niet slecht om friendsofphp/php-cs-fixer in --dev te includen en PHP_CS_FIXER_FUTURE_MODE=1 php ./vendor/bin/php-cs-fixer fix -v --dry-run --diff toe te voegen om die indents te fixen
src/Entity/BlacklistEmail.php
Outdated
| @@ -4,11 +4,12 @@ | |||
|
|
|||
| class BlacklistEmail | |||
| { | |||
| // @phpstan-ignore-next-line | |||
There was a problem hiding this comment.
hiervoor kan je phpstan/phpstan-doctrine toevoegen. Dan in phpstan.neon:
includes:
- vendor/phpstan/phpstan-doctrine/extension.neon
parameters:
doctrine:
objectManagerLoader: tests/object-manager.php
Ik kan je een object-mapper..php file doorsturen.
ChuckCCW
force-pushed
the
feature/SANTA-222
branch
from
1cbd688
to
1b90461
Compare
No description provided.