Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omit_if_nil_on to matching mode attributes #278

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add omit_if_nil_on to matching mode attributes #278

merged 1 commit into from
Sep 27, 2023

Conversation

phylor
Copy link
Collaborator

@phylor phylor commented Sep 27, 2023

Because dropoff_mode and pickup_mode are optional attributes, we should not send them if they are nil.

tom-ioki
tom-ioki approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@tom-ioki tom-ioki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright 👍

@phylor phylor merged commit 0ea8a04 into main Sep 27, 2023
2 checks passed
@phylor phylor deleted the fix/matching-mode-omit-if-nil branch September 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-ioki tom-ioki tom-ioki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phylor @tom-ioki