avoid private _utils import #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
avoid-private-import
branch
from
406f9b7 to
b66f7fb
Compare
ion-elgreco
reviewed
Mar 14, 2024
| @@ -158,10 +148,9 @@ def to_coords(self) -> pl.Expr: | |||
|
|
|||
| def from_coords(self, len: int | str | pl.Expr = 12) -> pl.Expr: | |||
| """Takes Struct with latitude, longitude as input and returns utf8 hash using geohash.""" | |||
| len_expr = wrap_expr(parse_as_expression(len)) | |||
There was a problem hiding this comment.
This one I believe still needs to used because input can also be int or str,
There was a problem hiding this comment.
wouldn't Polars take care of this here
?
so long as self is an expression, I think it should be fine
There was a problem hiding this comment.
Ah I did not know that :) that's nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_utilsis private and can change without warningBut I don't think you need this anyway, as
register_expressioncallsparse_as_expressionon its inputs anyway