Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): clean up ancestor nodes on resolve #6094

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

There seem to be more references attached to nodes themselves that cause memory issues.

What is the new behavior?

Clean up these references.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

n/a

Other information

n/a

@christian-bromann christian-bromann requested a review from a team as a code owner January 15, 2025 01:56
Copy link

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@christian-bromann christian-bromann added this pull request to the merge queue Jan 16, 2025
@christian-bromann christian-bromann removed this pull request from the merge queue due to a manual request Jan 16, 2025
@christian-bromann christian-bromann merged commit 2503dc5 into main Jan 16, 2025
72 checks passed
@christian-bromann christian-bromann deleted the cb/memory-leak-ancestor-fix branch January 16, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants