Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVEs in golang.org/x/crypto #499

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

jriedel-ionos
Copy link
Contributor

What does this fix or implement?

The package golang.org/x/crypto had two CVEs, which are fixed by bumping to the newest version.

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Sonar Cloud Scan
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

@jriedel-ionos jriedel-ionos marked this pull request as draft February 17, 2025 15:30
@avirtopeanu-ionos
Copy link
Contributor

avirtopeanu-ionos commented Feb 24, 2025

Hi! Thanks for opening this PR!

The chosen versions are great, but can you please run go mod vendor and go mod tidy and add the missing vendor files?
For example,these are missing from the vendor directory:

vendor/golang.org/x/crypto/chacha20/chacha_ppc64x.go
vendor/golang.org/x/crypto/chacha20/chacha_ppc64x.s
vendor/golang.org/x/crypto/internal/poly1305/sum_ppc64x.go
vendor/golang.org/x/crypto/internal/poly1305/sum_ppc64x.s
...

Thanks!

And don't mind the failing CIs, it's because your fork can't read our repo secrets.

Alternatively, just say the word and I can add those vendorfiles myself

@jriedel-ionos
Copy link
Contributor Author

Hi! Thanks for opening this PR!

The chosen versions are great, but can you please run go mod vendor and go mod tidy and add the missing vendor files? For example,these are missing from the vendor directory:

vendor/golang.org/x/crypto/chacha20/chacha_ppc64x.go
vendor/golang.org/x/crypto/chacha20/chacha_ppc64x.s
vendor/golang.org/x/crypto/internal/poly1305/sum_ppc64x.go
vendor/golang.org/x/crypto/internal/poly1305/sum_ppc64x.s
...

Thanks!

And don't mind the failing CIs, it's because your fork can't read our repo secrets.

Alternatively, just say the word and I can add those vendorfiles myself

Thank you, I already ran these commands and pushed it, if I do it again I don't get any diff locally. So yeah, please try it :D

@jriedel-ionos jriedel-ionos marked this pull request as ready for review February 24, 2025 10:00
Copy link
Contributor

@avirtopeanu-ionos avirtopeanu-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@avirtopeanu-ionos avirtopeanu-ionos merged commit 6c2769e into ionos-cloud:master Feb 24, 2025
1 of 6 checks passed
@jriedel-ionos jriedel-ionos deleted the fix-cves branch February 24, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants