User check mode #208
Merged
User check mode #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output, add tests
mimihalescu
approved these changes
Aug 27, 2024
|
rmocanu-ionos
added a commit
that referenced
this pull request
Aug 27, 2024
* fix: mark RegEx pattern as a raw string (#200) * feat: use filters to speed up users_get (#204) * fix: stop trying to use pagination for groups_users_get, add query params to get_users * fix: check if filters is None * fix: import get_users * fix: use none as default value * fix: make two calls to get users for all given emails * test: fix s3key test * test: added some user tests * feat: use getById when id is available * feat: use filters when we retrieve users in other modules when possible * feat: added ignored_properties to user (#205) * feat: added ignored_properties to user * test: fix s3key test * feat: user check mode (#208) * feat: working on adding checkmode and diff support for user * feat: added method to calculate diff for objects * chore: reverted small changes * fix: use existing values for diff if none are set to avoid changes in output, add tests * test: fix s3 key test * test: fix user test * chore: user return for check_mode for clarity * doc: added docs for check_mode and diff, fix typo, added to summary * chore: increment version, added check_mode doc file * [no ci] doc: regenerated docs * doc: updated changelog, changed version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Fixes #202
Checklist